chore: add ar, de, lo, sq to DDEShellPackageMacros.cmake#1220
Merged
Conversation
添加 ar, de, lo, sq 四个语言到 DDEShellPackageMacros 配置文件中 Log:
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdated DDEShellPackageMacros.cmake to register four additional translation files (Arabic, German, Lao, Albanian) in the package translation routine by appending their .ts paths to the TRANSLATION_FILES list. Class diagram for updated translation file registration in DDEShellPackageMacros.cmakeclassDiagram
class ds_handle_package_translation {
+TRANSLATION_FILES: list
+register_translation_files()
}
ds_handle_package_translation : +ar (.ts)
ds_handle_package_translation : +de (.ts)
ds_handle_package_translation : +lo (.ts)
ds_handle_package_translation : +sq (.ts)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review代码审查意见：
改进建议：
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @BLumia - I've reviewed your changes - here's some feedback:
- Ensure the new .ts translation files for ar, de, lo, and sq are actually added to the translations directory and committed.
- Consider extracting this hard-coded list of language codes into a sorted variable or loop to simplify maintenance and avoid manual ordering mistakes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure the new .ts translation files for ar, de, lo, and sq are actually added to the translations directory and committed.
- Consider extracting this hard-coded list of language codes into a sorted variable or loop to simplify maintenance and avoid manual ordering mistakes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
18202781743
approved these changes
Aug 11, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
添加 ar, de, lo, sq 四个语言到 DDEShellPackageMacros 配置文件中
Summary by Sourcery
Enhancements: